Remove deprecated std::binary_function inheritance for C++17 compatibility#56
Merged
niltonvasques merged 5 commits intooxeanbits:masterfrom Sep 1, 2025
Merged
Conversation
…ations-parser library: binary_function -> Enable WebAssembly on it
Victorcorcos
requested review from
tiagogoncalves
and removed request for
niltonvasques
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::binary_function<TString, TString, bool>inheritance fromSortByLengthstruct inparser/suSortPred.hstd::binary_functionwas removed from the standardREADME.mdwith a muuuch better version of itDetails
The
std::binary_functionbase class was deprecated in C++11 and removed in C++17. TheSortByLengthfunctor doesn't need this inheritance as it already provides the requiredoperator()method. This change maintains full functionality while ensuring compatibility with C++17 and later standards, which is necessary for WebAssembly compilation.Test plan